Github
/
vmware-host-modules
mirror of
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vmmon: use get_user_pages to get page PFN 

As a side effect of mainline commit 0d940a9b270b ("mm/pgtable: allow
pte_offset_map[_lock]() to fail") in 6.5-rc1, __pte_offset_map(), called by
pte_offset_map(), is no longer exported.

Based on an upstream IRC discussion and the hva_to_pfn_*() family of
functions in KVM code, what PgtblVa2MPNLocked() does seems to be an
incomplete and partial open coded logic of get_user_pages() and as it is
only used to get PFN from a virtual address, it can be easily implemented
using get_user_pages() family.

Without knowledge what exactly are the PFNs used for in VMware, it is hard
to guess the right flags, these seem to work and have been tested by
multiple users over last few weeks.

We could likely use get_user_pages() also on older kernels and it might be
actually cleaner and more reliable as existing open coded implementation
does not seem to handle some corner cases but without knowledge of VMware
internals, it will be safer to stick to existing code where possible.
This commit is contained in:
Michal Kubecek 2023-09-29 11:09:25 +02:00
parent d2c68f4472
commit 91e1fa732d
1 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
vmmon-only/include/pgtbl.h
View File

@ -25,6 +25,7 @@
#include "compat_pgtable.h"
#include "compat_spinlock.h"
#include "compat_page.h"
#include "compat_version.h"
/*
@ -45,6 +46,7 @@
*-----------------------------------------------------------------------------
*/
#if COMPAT_LINUX_VERSION_CHECK_LT(6, 5, 0) // only used by PgtblVa2MPN() below
static INLINE MPN
PgtblVa2MPNLocked(struct mm_struct *mm, // IN: Mm structure of a process
VA addr) // IN: Address in the virtual address
@ -106,6 +108,7 @@ PgtblVa2MPNLocked(struct mm_struct *mm, // IN: Mm structure of a process
}
return mpn;
}
#endif
/*
@ -125,6 +128,8 @@ PgtblVa2MPNLocked(struct mm_struct *mm, // IN: Mm structure of a process
*-----------------------------------------------------------------------------
*/
#if COMPAT_LINUX_VERSION_CHECK_LT(6, 5, 0)
static INLINE MPN
PgtblVa2MPN(VA addr) // IN
{
@ -139,4 +144,24 @@ PgtblVa2MPN(VA addr) // IN
return mpn;
}
#else /* COMPAT_LINUX_VERSION_CHECK_LT(6, 5, 0) */
static INLINE MPN
PgtblVa2MPN(VA addr) // IN
{
struct page *page;
int npages;
MPN mpn;
npages = get_user_pages_unlocked(addr, 1, &page, FOLL_HWPOISON);
if (npages != 1)
return INVALID_MPN;
mpn = page_to_pfn(page);
put_page(page);
return mpn;
}
#endif /* COMPAT_LINUX_VERSION_CHECK_LT(6, 5, 0) */
#endif /* __PGTBL_H__ */