Github
/
FTL
mirror of
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reduce allocated memory when determining process names. This possible buffer overflow by one byte (which should, however, be impossible to exploit). Thanks to Raymond Weber for pointing this out! 

Signed-off-by: DL6ER <dl6er@dl6er.de>
This commit is contained in:
DL6ER 2022-04-25 20:43:55 +02:00
parent 9f18ca5e4f
commit 1dcc375752
No known key found for this signature in database
GPG Key ID: 00135ACBD90B28DD
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/procps.c
View File

@ -17,7 +17,7 @@
#define PROCESS_NAME "pihole-FTL"
static bool get_process_name(const pid_t pid, char name[128])
static bool get_process_name(const pid_t pid, char name[16])
{
if(pid == 0)
{
@ -33,7 +33,7 @@ static bool get_process_name(const pid_t pid, char name[128])
return false;
// Read name from opened file
if(fscanf(f, "%128s", name) != 1)
if(fscanf(f, "%15s", name) != 1)
false;
fclose(f);
@ -111,7 +111,7 @@ bool check_running_FTL(void)
continue;
// Get process name
char name[128] = { 0 };
char name[16] = { 0 };
if(!get_process_name(pid, name))
continue;
@ -123,7 +123,7 @@ bool check_running_FTL(void)
pid_t ppid;
if(!get_process_ppid(pid, &ppid))
continue;
char ppid_name[128] = { 0 };
char ppid_name[16] = { 0 };
if(!get_process_name(ppid, ppid_name))
continue;